On 20.01.2016 20:21, Jeremy Huddleston Sequoia wrote:
This series includes 3 changes related to help reconcile the differences in
declaration between Apple's vs Mesa's GLhandleARB type. The first, I expect to
be mostly uncontroversial as they are mainly cleaning up and correcting some
prototypes. The second is just a casting which should be fine. The last adds
a bit of overhead to mesa_GetAttachedObjectsARB because we need to walk the
returned array of GLuint and copy into the array of GLhandleARB. I expect this
last one will be a bit unwelcome on platforms where these two types are the
same.
Would it be best to have a configure check for this and use it here (and maybe
elsewhere in the future), or would you prefer to just use a platform
preprocessing check for this since I suspect darwin is (and will only ever be)
the only impacted platform.
It's not like one would expect programs to call GetAttachedObjectsARB in
a fast path. I think the approach of patch 3 is fine (and actually
better, because it has less potential for future breakage), except for
the comments I sent you.
Cheers,
Nicolai
--Jeremy
_______________________________________________
mesa-dev mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
_______________________________________________
mesa-dev mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
