On 2016-02-13 22:01:46, Jordan Justen wrote: > On 2016-02-13 18:14:17, Jason Ekstrand wrote: > > > > Jason Ekstrand (21): > > nir/glsl: Remove dead function parameter handling code > > nir: Add a new "param" variable mode for parameters and return > > variables > > nir: Add a helper for creating a "bare" nir_function_impl > > Yeah, I suppose you could move the param init bits to the next patch. > It seems a little better, but also not too important to me. > > > nir: Create function parameters in function_impl_create > > nir/print: Factor variable name lookup into a helper > > nir/print: Better function argument printing > > nir/validate: Better function validation > > nir/clone: Add support for cloning a single function_impl > > 1-8 Reviewed-by: Jordan Justen <jordan.l.jus...@intel.com> > > > nir: Add a phi node placement helper > > nir/dominance: Handle unreachable blocks > > nir/vars_to_ssa: Use the new nir_phi_builder helper > > util/bitset: Allow iterating over const bitsets > > nir: Add a pass to repair SSA form > > nir/cf: Handle relinking top-level blocks > > nir: Add a function for comparing cursors > > nir/cf: Make extracting or re-inserting nothing a no-op > > nir/builder: Add a helper for inserting jump instructions > > nir: Add a cursor helper for getting a cursor after any phi nodes > > nir: Add return lowering pass
In the commit message, how about something like: "If the return is in a loop, it is lowered to a break. (With a flag that we will need to handle the return after the loop.)" > > nir/builder: Add helpers for easily inserting copy_var intrinsics > > nir: Add a pass to inline functions > > Series Reviewed-by: Jordan Justen <jordan.l.jus...@intel.com> _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
