On 03/02/2016 02:14 AM, Dave Airlie wrote:
On 1 March 2016 at 19:04, Eduardo Lima Mitev <[email protected]> wrote:
Hi,
I have sent updates for some of the patches, fixing a few dEQP regressions
we found, as well as rebase conflicts.
At this point, we don't have a any piglit or dEQP regression (GLES3 or
GLES31).
I was wondering if we maybe split the series in smaller sets, it would help
review. Like for example, a first set only introducing the new driver hook
to query1, then another set with query2 stuff, then the i965 bits.
Would that help?
BTW, this series continues to be updated at git tree:
https://github.com/Igalia/mesa/tree/internalformat-query2
Okay I've laid eyes on every single patch in the series, and I've spent some
time poking around the final result in the git tree.
Apart from what I've said before this, with those things addressed I'm happy
that this code is in as good shape as anything I've ever landed.
(the whitespace and the GL3.2 depend).
Hi Dave,
I have fixed locally the whitespace and the declaration-after-code
issues. Regarding the GL3.2 dependency, I submitted an v2 patch (39/65),
which I appreciate you look at to confirm it also has your R-b.
Reviewed-by: Dave Airlie <[email protected]>
Thanks a whole lot for the review! We will let one day go before
pushing, in case there are last minute comments.
cheers,
Eduardo
Dave.
_______________________________________________
mesa-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
