On 14.04.2016 03:59, Francisco Jerez wrote: > Michel Dänzer <[email protected]> writes: > >> From: Michel Dänzer <[email protected]> >> >> createInternalizePass now takes a callback instead of a StringSet. >> >> Signed-off-by: Michel Dänzer <[email protected]> >> --- >> src/gallium/state_trackers/clover/llvm/invocation.cpp | 17 +++++++++++++++++ >> 1 file changed, 17 insertions(+) >> >> diff --git a/src/gallium/state_trackers/clover/llvm/invocation.cpp >> b/src/gallium/state_trackers/clover/llvm/invocation.cpp >> index 4d11c24..97acd03 100644 >> --- a/src/gallium/state_trackers/clover/llvm/invocation.cpp >> +++ b/src/gallium/state_trackers/clover/llvm/invocation.cpp >> @@ -322,6 +322,18 @@ namespace { >> // list of kernel functions to the internalizer. The internalizer >> will >> // treat the functions in the list as "main" functions and internalize >> // all of the other functions. >> +#if HAVE_LLVM >= 0x0309 >> + auto preserve_kernels = [=](const llvm::GlobalValue &GV) { >> + for (std::vector<llvm::Function *>::const_iterator I = >> kernels.begin(), >> + E = >> kernels.end(); >> + I != E; ++I) { >> + llvm::Function *kernel = *I; > > 'for (const auto &kernel : kernels) {' instead of the last four lines of > code? With my style nitpick taken into account: > > Reviewed-by: Francisco Jerez <[email protected]>
Pushed with your suggestion, thanks (also to Tom for the review of my original patch). -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer
signature.asc
Description: OpenPGP digital signature
_______________________________________________ mesa-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/mesa-dev
