Adding the list back in... On Thu, Apr 14, 2016 at 6:05 PM, Jason Ekstrand <[email protected]> wrote:
> > > On Thu, Apr 14, 2016 at 5:52 PM, Rob Clark <[email protected]> wrote: > >> On Thu, Apr 14, 2016 at 7:23 PM, Jason Ekstrand <[email protected]> >> wrote: >> > >> > On Apr 14, 2016 4:15 PM, "Connor Abbott" <[email protected]> wrote: >> >> >> >> On Wed, Apr 13, 2016 at 7:45 PM, Jason Ekstrand <[email protected]> >> >> wrote: >> >> > I just rebased your patches (I grabbed the v2 from your >> freedesktop.org) >> >> > on >> >> > latest master and sedjob'd them to switch the order of parameters. >> You >> >> > can >> >> > find it here: >> >> > >> >> > >> >> > >> https://cgit.freedesktop.org/~jekstrand/mesa/log/?h=wip/nir-foreach-block-v3 >> >> >> >> Ok, well if you're willing to do the work then I'm fine with it :) >> > >> > It wasn't much work. I just did git format-patch, ran sed on the >> patches, >> > and did git am. >> > >> >> should I send out the modified patch 1, or will you, or...? >> > >> > I don't care too much about a resend. Just don't resend everything. I >> > haven't really looked at them hard enough to give a review yet. Too >> busy >> > trying to land a Vulkan driver. :-) >> > >> > I'll see if I can't get them reviewed yet this week though. >> > >> >> jfyi, not sure what the odds of getting nir/gallium stuff landed in >> next week (still got a couple patches I guess I need to bribe someone >> to review).. >> >> but if jason's branch is close enough to final (at least from PoV of >> nir lowering passes) I could rebase on that and add squashable patches >> on to (which could either be squashed into original patches or added >> on top depending on what order things go) >> > > I've had it kicking around my brain long enough that I'm willing to say I > like the concept and we should go forward with it. > > Here's what i'd like to do: > > 1) Merge the rename patch ASAP and we'll all rebase on that. Feel free > to add my R-B or I'll just add it and push. > 2) Merge all but the last patch as soon as we get the kinks worked out. > 3) Merge the last patch (that deletes nir_foreach_block_call) only after > we've all had a chance to fix up our outstanding branches. > > Seem reasonable to everyone? > --Jason >
_______________________________________________ mesa-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/mesa-dev
