On Fri, Apr 22, 2016 at 6:58 PM, Nanley Chery <[email protected]> wrote:
> On Fri, Apr 22, 2016 at 05:22:13PM -0700, Jason Ekstrand wrote: > > On Fri, Apr 22, 2016 at 4:38 PM, Nanley Chery <[email protected]> > wrote: > > > > > From: Nanley Chery <[email protected]> > > > > > > Sampling from an ETC2 texture is supported on Bay Trail and > > > from Gen8 onwards. While ASTC_LDR is supported on Gen9, the > > > logic to handle such formats has not yet been implemented in > > > the driver. > > > > > > Fixes dEQP-VK.api.info.format_properties.compressed_formats. > > > > > > v2: Enable ETC2 for Bay Trail (Kenneth Graunke) > > > > > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=94896 > > > Signed-off-by: Nanley Chery <[email protected]> > > > --- > > > src/intel/vulkan/anv_device.c | 5 +++-- > > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > > > diff --git a/src/intel/vulkan/anv_device.c > b/src/intel/vulkan/anv_device.c > > > index 00edd95..4abcdf9 100644 > > > --- a/src/intel/vulkan/anv_device.c > > > +++ b/src/intel/vulkan/anv_device.c > > > @@ -380,8 +380,9 @@ void anv_GetPhysicalDeviceFeatures( > > > .alphaToOne = true, > > > .multiViewport = true, > > > .samplerAnisotropy = false, /* FINISHME > */ > > > - .textureCompressionETC2 = true, > > > - .textureCompressionASTC_LDR = true, > > > + .textureCompressionETC2 = pdevice->info->gen > >= 8 > > > || > > > + > > > pdevice->info->is_baytrail, > > > + .textureCompressionASTC_LDR = false, /* FINISHME > */ > > > > > > > So... I thought that when I turned this on it passed all the ASTC CTS > > tests. We should double-check that before turning it off. > > --Jason > > > > We currently pass the dEQP-VK.api.info.format_properties.astc* tests > because they don't penalize the driver for advertising a featureless > format (VkFormatProperties = {0}) when the format isn't required. The > compressed_formats test fails however, because it actually references > VkPhysicalDeviceFeatures and sees the discrepancy. > Ok. We should try turning them on at some point and see how far we get on the CTS tests. > - Nanley > > > > > > .textureCompressionBC = true, > > > .occlusionQueryPrecise = true, > > > .pipelineStatisticsQuery = false, > > > -- > > > 2.8.0 > > > > > > _______________________________________________ > > > mesa-dev mailing list > > > [email protected] > > > https://lists.freedesktop.org/mailman/listinfo/mesa-dev > > > >
_______________________________________________ mesa-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/mesa-dev
