Samuel Iglesias Gonsálvez <[email protected]> writes: > From: Connor Abbott <[email protected]> > > --- > src/mesa/drivers/dri/i965/brw_fs.cpp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp > b/src/mesa/drivers/dri/i965/brw_fs.cpp > index ac170d5..729c7a0 100644 > --- a/src/mesa/drivers/dri/i965/brw_fs.cpp > +++ b/src/mesa/drivers/dri/i965/brw_fs.cpp > @@ -889,7 +889,7 @@ fs_inst::regs_read(int arg) const > return 0; > case UNIFORM: > case IMM: > - return 1; > + return DIV_ROUND_UP(type_sz(src[arg].type), 4);
This seems wrong to me, regs_read(i) returns the amount of data read by source i of the instruction in 32B units, and this makes it behave inconsistently for uniforms and immediates -- Please don't, this can potentially break assumptions throughout the back-end anywhere regs_read() is used, reg_offset being inconsistent between uniforms and VGRFs is already enough of a hassle... > case ARF: > case FIXED_GRF: > case VGRF: > -- > 2.5.0 > > _______________________________________________ > mesa-dev mailing list > [email protected] > https://lists.freedesktop.org/mailman/listinfo/mesa-dev
signature.asc
Description: PGP signature
_______________________________________________ mesa-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/mesa-dev
