With the version cutoff fixed, this and the patch it builds on are (squashed together or not):
Reviewed-by: Chris Forbes <[email protected]> On Fri, May 13, 2016 at 4:58 PM, Ilia Mirkin <[email protected]> wrote: > On Fri, May 13, 2016 at 12:51 AM, Dave Airlie <[email protected]> wrote: > >>> second argument is for ES... 0 means "never"). > >> > >> I see. (You can tell how much of this sort of code I've written...). > >> > >> I don't know that I'd trust me but it looks fine as far add I can see. > >> Thanks for taking care of 4.50 while you were in the neighborhood. For > what > >> it's worth, > > > > Do we know if the addition of swizzles and just correcting an oversight? > > > > Should we just enable it unconditionally. > > Good question. > > Looks like the cut-off is actually 4.40, not 4.50 (oops). I don't see > it explicitly listed in changes of the 4.40 spec. > > In 4.30: "For all of the interpolation functions, interpolant must be > an input variable or an element of an input > variable declared as an array. Component selection operators (e.g., > .xy) may not be used when specifying > interpolant." > > In 4.40: "For all of the interpolation functions, interpolant must be > an input variable or an element of an input > variable declared as an array. Component selection operators (e.g., > .xy) may be used when specifying > interpolant." > > I'd say it's pretty clear that it's not allowed in 4.30 and allowed in > 4.40. I'm going to fix the version cut-off locally, but if you want me > to enable it everywhere, let me know. > > -ilia > _______________________________________________ > mesa-dev mailing list > [email protected] > https://lists.freedesktop.org/mailman/listinfo/mesa-dev >
_______________________________________________ mesa-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/mesa-dev
