On Tue, May 17, 2016 at 3:21 AM, Eduardo Lima Mitev <el...@igalia.com> wrote: > brw_fs.cpp: In function ‘const unsigned int* brw_compile_fs(const [...] > brw_fs.cpp:6093:64: warning: ‘simd16_grf_start’ may be used uninitialized > [...] > prog_data->base.dispatch_grf_start_reg = simd16_grf_start; > > brw_fs.cpp:5996:29: note: ‘simd16_grf_start’ was declared here > uint8_t simd8_grf_start, simd16_grf_start; > > brw_fs.cpp:6094:52: warning: ‘simd16_grf_used’ may be used uninitialized [...] > prog_data->reg_blocks_0 = brw_register_blocks(simd16_grf_used); > > brw_fs.cpp:5997:29: note: ‘simd16_grf_used’ was declared here > unsigned simd8_grf_used, simd16_grf_used; > > (and more) > --- > src/mesa/drivers/dri/i965/brw_fs.cpp | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp > b/src/mesa/drivers/dri/i965/brw_fs.cpp > index 06a5de1..97341db 100644 > --- a/src/mesa/drivers/dri/i965/brw_fs.cpp > +++ b/src/mesa/drivers/dri/i965/brw_fs.cpp > @@ -5993,8 +5993,8 @@ brw_compile_fs(const struct brw_compiler *compiler, > void *log_data, > shader); > > cfg_t *simd8_cfg = NULL, *simd16_cfg = NULL; > - uint8_t simd8_grf_start, simd16_grf_start; > - unsigned simd8_grf_used, simd16_grf_used; > + uint8_t simd8_grf_start = 0, simd16_grf_start = 0; > + unsigned simd8_grf_used = 0, simd16_grf_used = 0; > > fs_visitor v8(compiler, log_data, mem_ctx, key, > &prog_data->base, prog, shader, 8, > -- > 2.7.0 > > _______________________________________________ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/mesa-dev
With the suggested change in patch 1, both patches are: Reviewed-by: Anuj Phogat <anuj.pho...@gmail.com> _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev