Reviewed-by: Samuel Iglesias Gonsálvez <sigles...@igalia.com> On 24/05/16 05:34, Francisco Jerez wrote: > This was introduced in cf375a3333e54a01462f192202d609436e5fbec8 but > the blame is mine because the pseudocode I sent in my review comment > for the original patch suggesting to do things this way already had > the off-by-one error. This may have caused copy propagation to be > unnecessarily strict while checking whether VGRF writes interfere with > any ACP entries and possibly miss valid optimization opportunities in > cases where multiple copy instructions write sequential locations of > the same VGRF. > > Cc: Iago Toral Quiroga <ito...@igalia.com> > Cc: Samuel Iglesias Gonsálvez <sigles...@igalia.com> > --- > src/mesa/drivers/dri/i965/brw_fs_copy_propagation.cpp | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/mesa/drivers/dri/i965/brw_fs_copy_propagation.cpp > b/src/mesa/drivers/dri/i965/brw_fs_copy_propagation.cpp > index b667b8c..eb5c00d 100644 > --- a/src/mesa/drivers/dri/i965/brw_fs_copy_propagation.cpp > +++ b/src/mesa/drivers/dri/i965/brw_fs_copy_propagation.cpp > @@ -756,8 +756,8 @@ inline bool > regions_overlap(const fs_reg &r, unsigned n, const fs_reg &s, unsigned m) > { > return r.file == s.file && r.nr == s.nr && > - !(r.reg_offset + n < s.reg_offset || > - s.reg_offset + m < r.reg_offset); > + !(r.reg_offset + n <= s.reg_offset || > + s.reg_offset + m <= r.reg_offset); > } > > /* Walks a basic block and does copy propagation on it using the acp >
signature.asc
Description: OpenPGP digital signature
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev