On 05/31/2016 07:10 AM, Brian Paul wrote:
On 05/29/2016 10:32 AM, Rob Clark wrote:
From: Rob Clark <[email protected]>

Another pipe_resource_usage vs pipe_transfer_usage mixup.

CID 1362169, 1362168

Signed-off-by: Rob Clark <[email protected]>
---
  src/gallium/drivers/svga/svga_resource_buffer.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/gallium/drivers/svga/svga_resource_buffer.c
b/src/gallium/drivers/svga/svga_resource_buffer.c
index d91497c..77b35b3 100644
--- a/src/gallium/drivers/svga/svga_resource_buffer.c
+++ b/src/gallium/drivers/svga/svga_resource_buffer.c
@@ -69,7 +69,7 @@ static void *
  svga_buffer_transfer_map(struct pipe_context *pipe,
                           struct pipe_resource *resource,
                           unsigned level,
-                         enum pipe_resource_usage usage,
+                         enum pipe_transfer_usage usage,
                           const struct pipe_box *box,
                           struct pipe_transfer **ptransfer)
  {


Reviewed-by: Brian Paul <[email protected]>


Actually, maybe that should be reverted to 'unsigned'.

The parameter is actually a bitmask of the PIPE_TRANSFER_x flags. We define those flags with the pipe_transfer_usage enum type.

But, IIRC, some compilers complain about using enums as bitmasks. I think this came up in the past but I don't recall the specifics.

I'll post a patch to revert to 'unsigned'.

-Brian


_______________________________________________
mesa-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Reply via email to