On Tue, May 31, 2016 at 12:03 PM, Emil Velikov <emil.l.veli...@gmail.com> wrote: > On 31 May 2016 at 18:54, Matt Turner <matts...@gmail.com> wrote: >> On Tue, May 31, 2016 at 9:26 AM, Emil Velikov <emil.l.veli...@gmail.com> >> wrote: >>> From: Emil Velikov <emil.veli...@collabora.com> >>> >>> Signed-off-by: Emil Velikov <emil.veli...@collabora.com> >>> --- >>> src/mapi/glapi/gen/Makefile.am | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/src/mapi/glapi/gen/Makefile.am b/src/mapi/glapi/gen/Makefile.am >>> index c511de9..ab0dcab 100644 >>> --- a/src/mapi/glapi/gen/Makefile.am >>> +++ b/src/mapi/glapi/gen/Makefile.am >>> @@ -58,6 +58,7 @@ BUILT_SOURCES = \ >>> $(MESA_GLX_DIR)/indirect_init.c \ >>> $(MESA_GLX_DIR)/indirect_size.h \ >>> $(MESA_GLX_DIR)/indirect_size.c >>> +CLEANFILE = $(BUILT_SOURCES) >>> EXTRA_DIST= \ >>> $(BUILT_SOURCES) \ >>> $(MESA_GLAPI_DIR)/glapi_gentable.c \ >>> -- >> >> Again doesn't this prevent you from rebuilding from a tarball after a >> make clean? > Can you please elaborate ? I believe that my argument for git_sha1.h > makes sense. Are you saying that the same/similar case applies here ?
From a tarball, if you run make clean it will delete files generated from python scripts. Since we don't require python to build from tarballs, there will be no way to regenerate them. Isn't that a problem? I don't think we should put these in CLEANFILES. _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
