On 06/03/2016 06:32 PM, Emil Velikov wrote:
Not sure who much the MESA>Mesa change matters, so I'll leave that to others.


Could break some applications that check for it. I doubt many do, and if they do I would suggest to make the change before Clover becomes popular, in hope this will be the case at some point.

+#ifdef MESA_GIT_SHA1
+                        " (" MESA_GIT_SHA1 ")"
+#endif
... but here please drop the ifdef guard. Same goes for the other file.


This is how OpenGL does it. Do you mind if I drop the include guard there as well?

Please give it some time for others to weight in before sending out v4.


Sure. Sorry for multiple revisions initially.

Regards,
Vedran

--
Vedran Miletić
vedran.miletic.net
_______________________________________________
mesa-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Reply via email to