[trimming cc's because mesa-dev hates them] On Tue, Jun 14, 2016 at 12:09 PM, Rob Clark <[email protected]> wrote: > On Tue, Jun 14, 2016 at 12:02 PM, Ilia Mirkin <[email protected]> wrote: >> Can you explain the motivation behind this change? I'm adding a >> ->set_window_rectangles thing which also takes multiple parameters. >> What's the advantage of stuffing things into a struct first? > > consistency with the other pipe->set_xyz APIs, and adding support for > it in rsq would then be a one line addition on rsq_state.py rather > than writing a bunch of code by hand ;-)
Sounds like it should be easy to extend your new script to handle different argument types easily, no? I don't know that the "this new script I wrote doesn't handle this situation well, so let's change a bunch of code" logic is the right one... -ilia _______________________________________________ mesa-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/mesa-dev
