On 6 July 2016 at 14:47, Emil Velikov <[email protected]> wrote: > On 6 July 2016 at 12:46, Emil Velikov <[email protected]> wrote: >> On 5 July 2016 at 22:13, Kenneth Graunke <[email protected]> wrote: >>> Otherwise it doesn't get automatically generated in a clean build. >>> >>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=96825 >>> Signed-off-by: Kenneth Graunke <[email protected]> >>> --- >>> src/intel/vulkan/Makefile.sources | 3 ++- >>> 1 file changed, 2 insertions(+), 1 deletion(-) >>> >>> diff --git a/src/intel/vulkan/Makefile.sources >>> b/src/intel/vulkan/Makefile.sources >>> index aa1459a..7303995 100644 >>> --- a/src/intel/vulkan/Makefile.sources >>> +++ b/src/intel/vulkan/Makefile.sources >>> @@ -66,7 +66,8 @@ VULKAN_GEM_STUB_FILES := \ >>> >>> VULKAN_GENERATED_FILES := \ >>> anv_entrypoints.c \ >>> - anv_entrypoints.h >>> + anv_entrypoints.h \ >>> + anv_timestamp.h >>> >> The rule below (already in the makefile) should handle the dependency >> and trigger the generation. Is that one failing even on clean builds ? >> >> anv_device.$(OBJEXT): anv_timestamp.h >> > To put some actual reasoning behind my query (slight reluctance): > - The above rule is taken from the automake manual [1] and should just > work(?) > - Using the above (proposed patch) will recreate anv_timestamp.h > again on the second `make {,install}' invocation, thus it the > anv_device.o (and final binary) will always get rebuild/relinked. Even > if there hasn't been any changes. > Noticed what's happening here, will send out a patch just after a fresh cup of coffee. Sadly the second point stands regardless of the method used, so we'll just have to live with it.
-Emil _______________________________________________ mesa-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/mesa-dev
