On Wed, Jul 20, 2016 at 9:50 PM, Kenneth Graunke <[email protected]> wrote: > On Thursday, July 21, 2016 2:07:01 PM PDT Timothy Arceri wrote: >> From: Timothy Arceri <[email protected]> >> >> We do this for all other stages. >> --- >> src/mesa/drivers/dri/i965/brw_gs.c | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/src/mesa/drivers/dri/i965/brw_gs.c >> b/src/mesa/drivers/dri/i965/brw_gs.c >> index d9f18c4..67a2480 100644 >> --- a/src/mesa/drivers/dri/i965/brw_gs.c >> +++ b/src/mesa/drivers/dri/i965/brw_gs.c >> @@ -163,6 +163,12 @@ brw_codegen_gs_prog(struct brw_context *brw, >> &prog_data, gs->Program->nir, prog, >> st_index, &program_size, &error_str); >> if (program == NULL) { >> + if (prog) {
Replying to Ken's mail, because I've lost the original. Coverity warns that prog has already been dereferenced, so this check is unnecessary and implies that prog may be NULL. >> + ralloc_strcat(&prog->InfoLog, error_str); >> + } >> + >> + _mesa_problem(NULL, "Failed to compile geometry shader: %s\n", >> error_str); >> + _______________________________________________ mesa-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/mesa-dev
