On 31.07.2016 22:29, Marek Olšák wrote:
Inspired by LLVM, I created a small test suite that looks like "lit" tests, 
except that the input is GLSL and it verifies asm.

The motivation was to verify that we generate optimal code when starting from 
GLSL.

[PATCH 1/3] radeonsi: add environment variable SI_FORCE_FAMILY
[PATCH 2/3] radeonsi: add a standalone compiler amdgcn_glslc
[PATCH 3/3] radeonsi: add GLSL lit tests

Good idea. Two comments:

Please use .glsl or some such instead of .ll as a file extension. Those files are not LLVM IR.

There's a `make check` in Mesa, which I readily admit to not using enough. There are r300_compiler_tests that are hooked up to it. Perhaps it's worth wiring that up?

Apart from that, the series is

Reviewed-by: Nicolai Hähnle <nicolai.haeh...@amd.com>



Please review.

Marek
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Reply via email to