On Friday, August 12, 2016 9:44:42 AM PDT Timothy Arceri wrote: > On Thu, 2016-08-11 at 13:43 -0700, Kenneth Graunke wrote: > > The previous commit fixed xfb_buffer handling, which was largely copy > > and pasted from the stream handling. The difference is that stream > > was set in input_layout_mask, so it worked. > > > > However, that's totally rubbish: stream is only valid on geometry > > shader > > outputs. Presumably this was to hack around inout. Instead, apply > > the > > solution I used in the previous fix. > > > > Really, we just need to separate shader interface and parameter > > qualifier handling so this isn't a mess, but this patch at least > > tidies it slightly. > > Agreed. I added a FIXME for this when I added input_layout_mask. Anyway > thanks for fixing this up. > > Series: > > Reviewed-by: Timothy Arceri <[email protected]>
Yup, I saw your FIXME and couldn't agree more. Then I thought about actually doing it and said 'ugghhhh', that'll probably be a mess :) Thanks!
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ mesa-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/mesa-dev
