On 2016-08-24 22:54:20, Pohjolainen, Topi wrote:
> On Wed, Aug 24, 2016 at 05:51:22PM -0700, Ian Romanick wrote:
> > On 08/24/2016 04:54 PM, Jordan Justen wrote:
> > > git://people.freedesktop.org/~jljusten/mesa hsw-es31-v1
> > > 
> > > Since gen7 doesn't support sampling from a stencil buffer, we copy the
> > > stencil texture to an R8_UINT texture, and sample from it instead.
> > > 
> > > This allows us to enable ARB_stencil_texturing and OpenGLES 3.1 on
> > > Haswell.
> > > 
> > > Ivy Bridge and Baytrail require additional (in progress) work to fix
> > > some integer border color sampling issues.
> > 
> > Once the IVB and BYT work lands, I'll send patches to enable the other
> > GL_OES_shader_io_blocks and GL_OES_geometry_shader on those platforms.
> > 
> > I sent a couple minor nits on 4, 10, and 12.  With or without those
> > changes, the series is
> > 
> > Reviewed-by: Ian Romanick <[email protected]>

Thanks!

> > It would still be good for someone who actually understands (ha!) the
> > miptree code to review too.
> 
> Well, at least another pair of eyes, 6-10 are also:
> 
> Reviewed-by: Topi Pohjolainen <[email protected]>

Thanks!

> I'm happy to see how simple this became in the end. Nice work Jordan!

Part 2 (ivb/byt) may turn that smile upside down. ;)
_______________________________________________
mesa-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Reply via email to