On Fri 02 Sep 2016, Nanley Chery wrote: > On Wed, Aug 31, 2016 at 08:29:55PM -0700, Nanley Chery wrote: > > From: Jason Ekstrand <jason.ekstr...@intel.com> > > > > Nanley Chery: > > (rebase) > > - Resolve conflicts with the new anv_batch_emit macro > > (amend) > > - Update commit title > > - Combine all HZ operations into one function > > - Add code for performing HiZ resolve operations > > - Add proper stencil and multisampling support > > - Set the proper clear rectangles > > - Add required cases for aborting an HZ operation > > > > Signed-off-by: Nanley Chery <nanley.g.ch...@intel.com> > > --- > > src/intel/vulkan/anv_genX.h | 3 + > > src/intel/vulkan/anv_private.h | 6 ++ > > src/intel/vulkan/gen7_cmd_buffer.c | 5 ++ > > src/intel/vulkan/gen8_cmd_buffer.c | 124 > > +++++++++++++++++++++++++++++++++++++ > > 4 files changed, 138 insertions(+)
> > + /* Apply alignment restrictions. For a sample count of 16, the > > formulas > > + * reduce to identity and indicate that no alignment is required. > > + */ > > + if (!full_surface_op && iview->image->samples < 16) { > > There may be a bug here. I plan to remove the samples < 16 condition because > when samples == 16, I'd expect the alignment will become 2x1, not 1x1. I also > need to take a second look at isl_msaa_interleaved_scale_px_to_sa to ensure it > returns the expected values. Ok. I'll wait for v2 before reviewing this patch. _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev