On Mon, Sep 12, 2016 at 8:37 AM, Emil Velikov <[email protected]> wrote: > From: Emil Velikov <[email protected]> > > A earlier sync with the Khronos headers added _extension_ prototype > guards to all the GLES2/3/31/32 core entry points. Effectively breaking > all the applications that aim to be portable and do not set the define. > > The issue has been reported to Khronos (internal bugzilla #14206) and is > being worked on. Until updated/fixed headers are released locally fix > the issue. > > The following report is when building weston. > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=97773 > > Cc: Armin Krezović <[email protected]> > Cc: Emmanuel Gil Peyrot <[email protected]> > Cc: Pekka Paalanen <[email protected]> > Fixes: 6a5504de2fb ("Update Khronos-supplied headers to r33100") > Cc: Ilia Mirkin <[email protected]> > Cc: Dave Airlie <[email protected]> > Signed-off-by: Emil Velikov <[email protected]>
Seems perfectly reasonable to me. IIRC I proposed something like this when the issue was first brought up. So this gets my Reviewed-by: Ilia Mirkin <[email protected]> Separately (i.e. doesn't have to be done in this change), now that the patches against KHR headers are growing (the apple thing, now this), perhaps we might consider keeping a diff checked into the tree so that it can be easily applied by the next poor sap who imports updated versions. Cheers, -ilia _______________________________________________ mesa-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/mesa-dev
