Hi Emil,
        What you mentioned about style issue in last round is:
                Please move the variable declaration in local scope and add 
space between ){
        I think I have fixed these issue in this version. Maybe I have 
misunderstood your meaning. Do you expect
the style like this:

                struct dri2_egl_display *dri2_dpy = dri2_egl_display(disp);
                struct dri2_egl_image *dri2_img = dri2_egl_image(img);
                EGLint img_offset = 0;

                (void) drv;

        Or this style (put the variable declaration at the beginning of local 

                if (offsets) {
                        EGLint img_offset = 0;
                        offsets[0] = 0;

Chuanbo Weng

-----Original Message-----
From: Emil Velikov [mailto:emil.l.veli...@gmail.com] 
Sent: Tuesday, September 20, 2016 5:13 AM
To: Jason Ekstrand <ja...@jlekstrand.net>
Cc: Weng, Chuanbo <chuanbo.w...@intel.com>; Nicolai Hähnle 
<nhaeh...@gmail.com>; mesa-dev@lists.freedesktop.org
Subject: Re: [Mesa-dev] [PATCH v3 0/3] Make eglExportDMABUFImageMESA return 
corresponding offset.

On 19 September 2016 at 16:38, Jason Ekstrand <ja...@jlekstrand.net> wrote:
> It all looks fine to me.  Feel free to add a
> Reviewed-by: Jason Ekstrand <ja...@jlekstrand.net>
> That said, my knowledge of the details of the DRI vfuncs is very 
> limited so I'd like to see Emil or Axel sign off on it too, especially 
> since they were the ones who had all the comments.
Thanks for double-checking Jason.

Afaics patches have a few outstanding style issues (mentioned last round), but 
I'll squash those just before committing tomorrow morning.

mesa-dev mailing list

Reply via email to