On Tue, Sep 27, 2016 at 8:03 PM, Brian Paul <bri...@vmware.com> wrote: > On 09/27/2016 05:17 PM, Steven Toth wrote: >> >> On Fri, Sep 23, 2016 at 12:19 PM, Brian Paul <bri...@vmware.com> wrote: >>> >>> Hi Steven, >>> >>> I did a more thorough review per your request... >> >> >> Thank you Brian. >> >> All of your suggestions have been implemented, and new patches pushed to >> the ML. > > > Were you planning on squashing the two patches? I think you should.
I will. I'll flatten and re-issue shortly. > > BTW, I see that some of the new changes could use const qualifiers. For > example: > > @@ -97,10 +97,10 @@ find_dsi_by_name(char *n, int mode) > } > > static int > -get_file_values(struct diskstat_info *dsi, struct stat_s *s) > +get_file_values(char *fn, struct stat_s *s) > > That could be 'const char *fn'. Same thing in other places. I'll look at this and make the changes. > > Sorry to be nit picky about const qualifiers, but they're pretty helpful > when reading code to help understand which arguments may or may not be > modified by a function. I'm good with nits, I appreciate the feedback. -- Steven Toth - Kernel Labs http://www.kernellabs.com _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
