Ben Widawsky <[email protected]> writes: > All mobile parts (so far) are GT1. The check added extra confusion > because it appeared Broxton was missing when it wasn't. Replace it with > a comment. > > Alternatively, I'd be willing to add an is_broxton check. > > Cc: Francisco Jerez <[email protected]> > Signed-off-by: Ben Widawsky <[email protected]> > --- > src/intel/common/gen_l3_config.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/src/intel/common/gen_l3_config.c > b/src/intel/common/gen_l3_config.c > index b172ef6..eb4e8ae 100644 > --- a/src/intel/common/gen_l3_config.c > +++ b/src/intel/common/gen_l3_config.c > @@ -258,7 +258,8 @@ get_l3_way_size(const struct gen_device_info *devinfo) > if (devinfo->is_baytrail) > return 2; > > - else if (devinfo->is_cherryview || devinfo->gt == 1) > + /* XXX: Cherryview and Broxton are always gt1 */ > + else if (devinfo->gt == 1)
An explicit devinfo->is_broxton check would be as informative as the comment (XXX?) and more obviously correct, because the GTn naming doesn't officially apply to mobile parts as far as I'm aware, so I'd definitely prefer the additional check. > return 4; > > else > -- > 2.10.0
signature.asc
Description: PGP signature
_______________________________________________ mesa-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/mesa-dev
