On Wed, Oct 26, 2016 at 2:00 PM, Jason Ekstrand <ja...@jlekstrand.net> wrote: > On Oct 26, 2016 12:51 PM, "Matt Turner" <matts...@gmail.com> wrote: >> >> --- >> src/intel/Makefile.genxml.am | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/src/intel/Makefile.genxml.am b/src/intel/Makefile.genxml.am >> index 2df223a..2ed2741 100644 >> --- a/src/intel/Makefile.genxml.am >> +++ b/src/intel/Makefile.genxml.am >> @@ -33,7 +33,7 @@ $(GENXML_GENERATED_FILES): genxml/gen_pack_header.py >> >> .xml_pack.h: >> $(MKDIR_GEN) >> - $(PYTHON_GEN) $(srcdir)/genxml/gen_pack_header.py $< > $@ >> + $(PYTHON_GEN) $(srcdir)/genxml/gen_pack_header.py $< > $@ || >> ($(RM) $@; false) > > Thanks for fixing this! I think the way we do this most other places is > with "> $@.tmp && mv $@.tmp $&” not that I care that much...
In fact, the opposite is true. We do the .tmp trick with the git sha1 file, but use what's done in this patch in multiple places in Makefile.glsl.am and Makefile.nir.am, and it's even spread to freedreno and i965. _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
