Reviewed-by: Marek Olšák <[email protected]> Marek
On Wed, Nov 2, 2016 at 4:32 PM, Emil Velikov <[email protected]> wrote: > From: Emil Velikov <[email protected]> > > The use of regparm causes an error on arm/arm64 builds with clang. > fastcall is allowed, but still throws a warning. As both options only > have effect on 32-bit x86 builds, limit them to that case. > > v2: keep the __i386__ within GCC (Nicolai) > > Cc: 13.0 <[email protected]> > Cc: Rob Herring <[email protected]> > Cc: Nicolai Hähnle <[email protected]> > Signed-off-by: Emil Velikov <[email protected]> > --- > I'm having doubts whether the whole "let's change calling conventions" > thing is worth the effort, but considering the "let's ignore standard > primitives/types and use the Windows ones" et al. it's pretty much > nothing ;-) > > </rant> > --- > src/amd/addrlib/addrtypes.h | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/src/amd/addrlib/addrtypes.h b/src/amd/addrlib/addrtypes.h > index 4c68ac5..4dd7bab 100644 > --- a/src/amd/addrlib/addrtypes.h > +++ b/src/amd/addrlib/addrtypes.h > @@ -88,7 +88,11 @@ typedef int INT; > > #ifndef ADDR_FASTCALL > #if defined(__GNUC__) > - #define ADDR_FASTCALL __attribute__((regparm(0))) > + #if defined(__i386__) > + #define ADDR_FASTCALL __attribute__((regparm(0))) > + #else > + #define ADDR_FASTCALL > + #endif > #else > #define ADDR_FASTCALL __fastcall > #endif > -- > 2.9.3 > > _______________________________________________ > mesa-dev mailing list > [email protected] > https://lists.freedesktop.org/mailman/listinfo/mesa-dev _______________________________________________ mesa-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/mesa-dev
