On 17 November 2016 at 17:33, Kyriazis, George <george.kyria...@intel.com> wrote: > > >> -----Original Message----- >> From: Emil Velikov [mailto:emil.l.veli...@gmail.com] >> Sent: Thursday, November 17, 2016 11:22 AM >> To: Kyriazis, George <george.kyria...@intel.com> >> Cc: ML mesa-dev <mesa-dev@lists.freedesktop.org> >> Subject: Re: [Mesa-dev] [PATCH v3 10/10] swr: Modify gen_knobs.{cpp|h} >> creation script >> >> On 16 November 2016 at 02:27, George Kyriazis <george.kyria...@intel.com> >> wrote: >> > Modify gen_knobs.py so that each invocation creates a single generated >> > file. This is more similar to how the other generators behave. >> Nicely done. >> >> > mode change 100644 => 100755 src/gallium/drivers/swr/Makefile.am >> Please don't ! >> > Sorry, don’t know how this got there. :-) > >> > >> > env.CodeGenerate( >> > - target = 'rasterizer/archrast/gen_ar.event.cpp', >> > + target = 'rasterizer/archrast/gen_ar_event.cpp', >> > script = swrroot + 'rasterizer/scripts/gen_archrast.py', >> > source = 'rasterizer/archrast/events.proto', >> > - command = python_cmd + ' $SCRIPT --proto $SOURCE --output $TARGET >> --gen-event_cpp' >> > + command = python_cmd + ' $SCRIPT --proto $SOURCE --output >> $TARGET --gen_event_cpp' >> Squash there with 8/10 >> >> >> > >> > -source = [ >> > +# Auto-generated .cpp files (that need to generate object files) >> > +built_sources = [ >> > 'rasterizer/scripts/gen_knobs.cpp', >> > 'rasterizer/jitter/builder_gen.cpp', >> > 'rasterizer/jitter/builder_x86.cpp', >> > + 'rasterizer/archrast/gen_ar_event.cpp', >> > ] >> > >> > +source = built_sources >> and these. >> >> With that >> 1-5 and 7-9 (with the bits squashed appropriately) are >> Reviewed-by: Emil Velikov <emil.veli...@collabora.com> >> >> 6/10 and the potential 5.5/10 need some work. >> > Can you please elaborate? Not sure what needs work. I've already fixed your > previous comment to use UTIL_DL_PREFIX and UTIL_DL_EXT. > Here (in this patch) you can see the exact bits. The 6/10 ones are listed in the patch :-)
-Emil _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev