On Thu, Dec 15, 2016 at 6:45 AM, Emil Velikov <[email protected]> wrote: > On 15 December 2016 at 01:10, Randy Xu <[email protected]> wrote: >> From: "Xu,Randy" <[email protected]> >> >> Refer to GLES3.2 spec in 8.5 >> Textures with a base internal format of DEPTH_COMPONENT, DEPTH_- >> STENCIL or STENCIL_INDEX are supported by texture image specification >> commands only if target is TEXTURE_2D, TEXTURE_2D_MULTISAMPLE, >> TEXTURE_2D_ARRAY, TEXTURE_2D_MULTISAMPLE_ARRAY, TEXTURE_CUBE_- >> MAP or TEXTURE_CUBE_MAP_ARRAY. Using these formats in conjunction with >> any other target will result in an INVALID_OPERATION error. >> This patch can fix dEQP-GLES3.functional.negative_api.texture.teximage3d
s/can fix/fixes/ >> failure. s/failure// >> > I think others have alluded it with referencing other commits, but it > might have been too subtle. > - please use the cannonical format [1] to add a spec quote in the code > - your commit message should explain why rather than a simple spec quote. > You can draw some inspirations from 19f13b2096a9fdd986e5a12d4e9d8b0d6a4632f3 And #3 - Matt pointed out that desktop GL actually has similar text. So the condition needs to be different (and will require some trudging through specs to figure out what happened). [Unless I misunderstood what he was saying, in which case, disregard.] -ilia _______________________________________________ mesa-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/mesa-dev
