On Tuesday, January 17, 2017 8:43:28 AM PST Eduardo Lima Mitev wrote: > If there is no plan to use brw_print_program_cache elsewhere, I would > rather keep it a static method where it is used. In general, I prefer > not polluting header files. Not a big deal anyway; feel free to ignore > the comment. > > Reviewed-by: Eduardo Lima Mitev <[email protected]>
I would've been happy to leave it there, but it uses the brw_cache_item structure. So unless we move it, we can't do patch 4, and the struct will remain exposed to the entire driver. I'd much rather export a print function and gain the encapsulation of having the data structures be local to the program cache code. Thanks for reviewing! --Ken
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ mesa-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/mesa-dev
