On Wed, Jan 18, 2017 at 11:49 PM, Andres Rodriguez <[email protected]> wrote: > The current message sounds like a small warning, clarify that it can > result in lack of presentation support and application crashes. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=98263 > Signed-off-by: Andres Rodriguez <[email protected]> > --- > src/vulkan/wsi/wsi_common_x11.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/src/vulkan/wsi/wsi_common_x11.c b/src/vulkan/wsi/wsi_common_x11.c > index 158446c..7479f74 100644 > --- a/src/vulkan/wsi/wsi_common_x11.c > +++ b/src/vulkan/wsi/wsi_common_x11.c > @@ -265,7 +265,8 @@ VkBool32 wsi_get_physical_device_xcb_presentation_support( > return false; > > if (!wsi_conn->has_dri3) { > - fprintf(stderr, "vulkan: No DRI3 support\n"); > + fprintf(stderr, "vulkan: No DRI3 support detected - required for > presentation\n"); > + fprintf(stderr, "Note: Buggy applications may crash, please report to > vendor\n"); Maybe an " if they do" at the end of it to clarify that it doesn't need to be reported if they don't crash?
Either way: Acked-by: Bas Nieuwenhuizen <[email protected]> > return false; > } > > @@ -313,7 +314,8 @@ x11_surface_get_support(VkIcdSurfaceBase *icd_surface, > return VK_ERROR_OUT_OF_HOST_MEMORY; > > if (!wsi_conn->has_dri3) { > - fprintf(stderr, "vulkan: No DRI3 support\n"); > + fprintf(stderr, "vulkan: No DRI3 support detected - required for > presentation\n"); > + fprintf(stderr, "Note: Buggy applications may crash, please report to > vendor\n"); > *pSupported = false; > return VK_SUCCESS; > } > -- > 2.9.3 > > _______________________________________________ > mesa-dev mailing list > [email protected] > https://lists.freedesktop.org/mailman/listinfo/mesa-dev _______________________________________________ mesa-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/mesa-dev
