On Wed, 2017-01-18 at 11:39 -0800, Matt Turner wrote: > On Wed, Jan 18, 2017 at 2:45 AM, Samuel Iglesias Gonsálvez > <sigles...@igalia.com> wrote: > > On Tue, 2017-01-17 at 13:33 -0800, Francisco Jerez wrote: > > > Samuel Iglesias Gonsálvez <sigles...@igalia.com> writes: > > > > > > > From: Matt Turner <matts...@gmail.com> > > > > > > > > On HSW+, scalar DF sources can be accessed using the normal > > > > <0,1,0> > > > > region, but on IVB and BYT DF regions must be programmed in > > > > terms > > > > of > > > > floats. A <0,2,1> region accomplishes this. > > > > > > Any reason you're doing this here twice instead of during fs_reg > > > to > > > brw_reg conversion? > > > > > > > I have modified locally this patch to do it in > > brw_reg_from_fs_reg(). > > Matt, if you agree with Curro's suggestion, I can keep the new > > version > > in my branch instead of this. > > I found your patch. Looks good to me. > > I just have one request: order the comparisons and assignments as > vstride, width, hstride -- the same way they appear in the <V,W,H> > regioning notation. >
OK, thanks Matt. Sam
signature.asc
Description: This is a digitally signed message part
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
