On 26/01/17 13:43, Eric Engestrom wrote:
On Thursday, 2017-01-26 11:27:00 +0000, Lionel Landwerlin wrote:
Fixes:
dEQP-VK.api.descriptor_pool.out_of_pool_memory
Signed-off-by: Lionel Landwerlin <lionel.g.landwer...@intel.com>
Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com>
But is there any reason not to add support for all the other errors in
vulkan.h as well?
>From core vulkan, these are also missing:
- VK_ERROR_FEATURE_NOT_PRESENT
- VK_ERROR_TOO_MANY_OBJECTS
- VK_ERROR_FORMAT_NOT_SUPPORTED
and from the extensions:
- VK_ERROR_SURFACE_LOST_KHR
- VK_ERROR_NATIVE_WINDOW_IN_USE_KHR
- VK_ERROR_INCOMPATIBLE_DISPLAY_KHR
- VK_ERROR_VALIDATION_FAILED_EXT
- VK_ERROR_INVALID_SHADER_NV
I can understand not having the extensions ones until we implement each
extension, but I'd be in favour of keeping this list in sync with vulkan.h,
so as not to forget.
I can't see any reason not to have the core errors, so I'm assuming these
were just forgotten to be added when vulkan.h got updated.
Fair comment. Let's wait to see whether Jason has any comment.
Thanks
Cheers,
Eric
---
src/intel/vulkan/anv_util.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/intel/vulkan/anv_util.c b/src/intel/vulkan/anv_util.c
index 6408ac87c7..5fbc7cc113 100644
--- a/src/intel/vulkan/anv_util.c
+++ b/src/intel/vulkan/anv_util.c
@@ -83,9 +83,11 @@ __vk_errorf(VkResult error, const char *file, int line,
const char *format, ...)
ERROR_CASE(VK_ERROR_LAYER_NOT_PRESENT)
ERROR_CASE(VK_ERROR_EXTENSION_NOT_PRESENT)
ERROR_CASE(VK_ERROR_INCOMPATIBLE_DRIVER)
+ ERROR_CASE(VK_ERROR_FRAGMENTED_POOL)
/* Extension errors */
ERROR_CASE(VK_ERROR_OUT_OF_DATE_KHR)
+ ERROR_CASE(VK_ERROR_OUT_OF_POOL_MEMORY_KHR)
default:
assert(!"Unknown error");
--
2.11.0
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
