On Thu, Jan 26, 2017 at 10:23 AM, Ian Romanick <i...@freedesktop.org> wrote:
> I keep seeing patches like this... is it time to move BITFIELD64_* from > mtypes.h to somewhere in util for more general use? > It may be time > On 01/26/2017 05:18 AM, Emil Velikov wrote: > > From: Emil Velikov <emil.veli...@collabora.com> > > > > MSVC warns about implicit conversion as below. Annotate the literal > > appropriately to silence the warning. > > > > nir_gather_info.c(249) : warning C4334: '<<' : result of 32-bit shift > > implicitly converted to 64 bits (was 64-bit shift intended?) > > > > Signed-off-by: Emil Velikov <emil.veli...@collabora.com> > > --- > > src/compiler/nir/nir_gather_info.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/src/compiler/nir/nir_gather_info.c > b/src/compiler/nir/nir_gather_info.c > > index 35a1ce4dec..0c70787252 100644 > > --- a/src/compiler/nir/nir_gather_info.c > > +++ b/src/compiler/nir/nir_gather_info.c > > @@ -246,7 +246,7 @@ gather_intrinsic_info(nir_intrinsic_instr *instr, > nir_shader *shader) > > case nir_intrinsic_load_tess_level_outer: > > case nir_intrinsic_load_tess_level_inner: > > shader->info->system_values_read |= > > - (1 << nir_system_value_from_intrinsic(instr->intrinsic)); > > + (1ull << nir_system_value_from_intrinsic(instr->intrinsic)); > > break; > > > > case nir_intrinsic_end_primitive: > > > > _______________________________________________ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/mesa-dev >
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
