On 28.02.2017 05:19, Dave Airlie wrote: > On 27 February 2017 at 06:31, Constantine Charlamov <hi-an...@yandex.ru> > wrote: >> Initially I was trying to implement for r600 optimization like in > the d633e23192ef17207f4a6acd3009da3126aab395 commit for radeonsi, but failed > because I need to learn some more about GPUs internals. For another time. > Anyway, accidentally it turned into a small cleanup of r600_shader.c, here it is. >> >> Hi-Angel (6): >> Get rid of trailing whitespace (trivial) >> Rename i→chan_index >> Replace bit-shifts and cycles with helpers from tgsi_exec.h >> Rename tgsi_last_instruction → tgsi_last_channel >> Get rid of tgsi_last_channel() wherever possible, rename lasti → >> last_chan >> Remove redudant comparisons > > > Have they passed a complete piglit run >> without regressions? > > Dave.
Hmm I don't know. Is there some specific test I should be running? I indeed tried ./piglit run shader results/shader --all-concurrent But there're 33k tests running with speed that would take 1-1.5 hours for every run (i.e. with and without changes). I can try it anyway, but I just suspect I'm doing something wrong because usually, when I see people mention piglit tests, there're amounts far less than 10k. _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev