On 4 March 2017 at 23:41, Timothy Arceri <tarc...@itsqueeze.com> wrote: > pipe_condvar_broadcast() was made unnecessary with fd33a6bcd7f12. Fwiw I have some patches that do a similar cleanups on the thrd_* side. Need to test them one of these days - since they're not as trivial of a sed job.
> --- > src/gallium/auxiliary/os/os_thread.h | 5 +---- > src/gallium/auxiliary/pipebuffer/pb_bufmgr_slab.c | 2 +- > src/gallium/auxiliary/util/u_queue.c | 4 ++-- > src/gallium/drivers/llvmpipe/lp_fence.c | 2 +- > src/gallium/drivers/rbug/rbug_core.c | 6 +++--- > 5 files changed, 8 insertions(+), 11 deletions(-) > > diff --git a/src/gallium/auxiliary/os/os_thread.h > b/src/gallium/auxiliary/os/os_thread.h > index a8b5d92..6eca2ca 100644 > --- a/src/gallium/auxiliary/os/os_thread.h > +++ b/src/gallium/auxiliary/os/os_thread.h > @@ -141,23 +141,20 @@ __pipe_mutex_assert_locked(pipe_mutex *mutex) > assert(ret == thrd_busy); > if (ret == thrd_success) > mtx_unlock(mutex); > #endif > } > > /* pipe_condvar > */ > typedef cnd_t pipe_condvar; > I think we should we drop this typedef one as well. We could also follow-up with pipe_tsd_* front ? In either case, it might be worth checking with Jose/others to update things on their end. For the series: Reviewed-by: Emil Velikov <emil.l.veli...@gmail.com> -Emil _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev