I would add a comment, at least in the commit log, explaining why these
limits are MAX_DYNAMIC_BUFFERS/2. It is not immediately evident.

In any case, patch is:

Reviewed-by: Eduardo Lima Mitev <[email protected]>

On 03/04/2017 08:05 PM, Jason Ekstrand wrote:
> Cc: "17.0 13.0" <[email protected]>
> ---
>  src/intel/vulkan/anv_device.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c
> index fbcbd40..3fc51ac 100644
> --- a/src/intel/vulkan/anv_device.c
> +++ b/src/intel/vulkan/anv_device.c
> @@ -565,9 +565,9 @@ void anv_GetPhysicalDeviceProperties(
>        .maxPerStageResources                     = 128,
>        .maxDescriptorSetSamplers                 = 256,
>        .maxDescriptorSetUniformBuffers           = 256,
> -      .maxDescriptorSetUniformBuffersDynamic    = 256,
> +      .maxDescriptorSetUniformBuffersDynamic    = MAX_DYNAMIC_BUFFERS / 2,
>        .maxDescriptorSetStorageBuffers           = 256,
> -      .maxDescriptorSetStorageBuffersDynamic    = 256,
> +      .maxDescriptorSetStorageBuffersDynamic    = MAX_DYNAMIC_BUFFERS / 2,
>        .maxDescriptorSetSampledImages            = 256,
>        .maxDescriptorSetStorageImages            = 256,
>        .maxDescriptorSetInputAttachments         = 256,
> 

_______________________________________________
mesa-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Reply via email to