On 7 March 2017 at 02:17, Matt Turner <matts...@gmail.com> wrote: > On Mon, Mar 6, 2017 at 4:57 PM, Emil Velikov <emil.l.veli...@gmail.com> wrote: >> On 6 March 2017 at 19:06, Matt Turner <matts...@gmail.com> wrote: >>> I was already tired of seeing the message >>> >>> Package libomxil-bellagio was not found in the pkg-config search path. >>> Perhaps you should add the directory containing `libomxil-bellagio.pc' >>> to the PKG_CONFIG_PATH environment variable >>> No package 'libomxil-bellagio' found >>> >>> on every configure, but I just got a distro bug reported where the user >>> was confused by this message and thought it indicated a bug. >>> --- >>> configure.ac | 3 ++- >>> 1 file changed, 2 insertions(+), 1 deletion(-) >>> >>> diff --git a/configure.ac b/configure.ac >>> index d483baa..8d78aa6 100644 >>> --- a/configure.ac >>> +++ b/configure.ac >>> @@ -2195,7 +2195,8 @@ AC_ARG_WITH([omx-libdir], >>> [AS_HELP_STRING([--with-omx-libdir=DIR], >>> [directory for the OMX libraries])], >>> [OMX_LIB_INSTALL_DIR="$withval"], >>> - [OMX_LIB_INSTALL_DIR=`$PKG_CONFIG --define-variable=libdir=\$libdir >>> --variable=pluginsdir libomxil-bellagio`]) >>> + [OMX_LIB_INSTALL_DIR=`$PKG_CONFIG --define-variable=libdir=\$libdir >>> --exists libomxil-bellagio && \ >> We don't need the --define-variable in the above case, do we ? With >> that fixed (or with comment in the summary why we need it) the whole > > I don't know why it's needed to begin with. I presume it's to handle a > case where OMX's plugindir is within some non-standard libdir > specified by the user. > > The "--define-variable=..." might be necessary, I don't know how to > test it, and I don't think it could hurt anything so I'd rather not > touch it. > IIRC --define... is there because of platforms (iirc Debian and friends) where libdir is not your average /usr/lib thus things would fail at runtime. Admittedly a better solution might have been to properly document things but meh.
Please include anything like your reply in the commit message. Thanks Emil _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev