On Wed, Mar 8, 2017 at 4:56 PM, Eric Anholt <e...@anholt.net> wrote: > Jason Ekstrand <ja...@jlekstrand.net> writes: > > > When NIR was first created, we were a bit lazy about numbers of > components. > > The rule was that a source couldn't consume more components than the > thing > > it was reading from. However, this leads to a lot of confusion because > you > > now have a thing sourcing from a vec4 but only reading two of the > > components. > > > > The solution to this is to disallow that case and require that the number > > of components always match. The one exception is ALU instructions > because > > they're designed to naturally swizzle things around like mad. We already > > require this restriction for phi instructions. This series adds it for > > intrinsics, texture instructions, and deref indirects. > > > > Cc: Kenneth Graunke <kenn...@whitecape.org> > > Cc: Connor Abbott <cwabbo...@gmaial.com> > > Other than the comments I gave, and needing to land the lowering patch, > this series is: > > Reviewed-by: Eric Anholt <e...@anholt.net> >
Thanks!
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
