On Thu, Mar 16, 2017 at 2:17 PM, Matt Turner <[email protected]> wrote:
> I started to add support to NIR for something like INTEL_DEBUG=optimizer, > but > then realized that a bunch of NIR passes didn't even return progress. > > After fixing that, I realized that a bunch of NIR passes didn't preserve > metadata. > > Sigh. > :( I think I may have seen a few more as I was reviewing but they're not passes we're calling. I also found an issue in patch 19 so I think that one needs a bit of work. 1-18 and 20-23 are Reviewed-by: Jason Ekstrand <[email protected]> I can't say I read them super-carefully so it's somewhere between an ack and a review (probably closer to the review side) but I didn't see anything amiss other than the issue on 19. --Jason > I have not tested radv, freedreno, or vc4, but I think that since I did not > replace their OPT_V/NIR_PASS_V everything should work just the same, and > allow > them to transition at their leisure. >
_______________________________________________ mesa-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/mesa-dev
