On Sunday, 2017-03-19 10:50:37 -0300, Fabio Estevam wrote:
> Hi Emil,
>
> On Sun, Mar 19, 2017 at 7:57 AM, Emil Velikov <emil.l.veli...@gmail.com>
> wrote:
> > On 18 March 2017 at 21:47, Fabio Estevam <feste...@gmail.com> wrote:
> >> There is no need to use brackets for single line if statements,
> >> so simply remove them.
> >>
> >> Signed-off-by: Fabio Estevam <feste...@gmail.com>
> > R-b and pushed to master.
> >
> > I'm wondering if piping the whole kmscube repo through something like
> > [the kernel's] checkpatch would be OK ?
> > Just an idea of course.
>
> Looks like a good idea to me.
>
> Thanks
Just had a look:
common.c
total: 1 errors, 6 warnings, 213 lines checked
common.h
total: 9 errors, 18 warnings, 93 lines checked
cube-smooth.c
total: 67 errors, 35 warnings, 273 lines checked
cube-tex.c
total: 67 errors, 96 warnings, 575 lines checked
drm-atomic.c
total: 1 errors, 36 warnings, 384 lines checked
drm-common.c
total: 1 errors, 15 warnings, 208 lines checked
drm-common.h
total: 3 errors, 1 warnings, 80 lines checked
drm-legacy.c
total: 1 errors, 1 warnings, 127 lines checked
esTransform.c
total: 32 errors, 130 warnings, 235 lines checked
esUtil.h
total: 64 errors, 82 warnings, 303 lines checked
frame-512x512-NV12.c
total: 0 errors, 12288 warnings, 12323 lines checked
frame-512x512-RGBA.c
total: 0 errors, 32768 warnings, 32803 lines checked
kmscube.c
total: 0 errors, 3 warnings, 132 lines checked
I'll have a look at fixing those later, but I think I'll ignore all
'line over 80 characters' ones (anyone knows which `--ignore` this is?
`--list-types` isn't that verbose).
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
