On Mar 23, 2017 11:00 PM, "Samuel Iglesias Gonsálvez" <[email protected]> wrote:
On Thu, 2017-03-23 at 11:09 -0700, Nanley Chery wrote: > On Thu, Mar 23, 2017 at 12:25:28PM +0100, Samuel Iglesias Gonsálvez > wrote: > > A resolve is not needed on Skylake in this case. We were forcing > > a resolve because we set the input_aux_usage to ISL_AUX_USAGE_NONE. > > > > Signed-off-by: Samuel Iglesias Gonsálvez <[email protected]> > > --- > > > > This doesn't fix the problem with BDW but I found it while > > reviewing > > the code. > > > > src/intel/vulkan/genX_cmd_buffer.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/src/intel/vulkan/genX_cmd_buffer.c > > b/src/intel/vulkan/genX_cmd_buffer.c > > index e2364dbfd52..39856b9af7c 100644 > > --- a/src/intel/vulkan/genX_cmd_buffer.c > > +++ b/src/intel/vulkan/genX_cmd_buffer.c > > @@ -305,8 +305,8 @@ color_attachment_compute_aux_usage(struct > > anv_device *device, > > * doesn't also support color compression. > > */ > > att_state->input_aux_usage = ISL_AUX_USAGE_NONE; > > - } else if (GEN_GEN == 8) { > > - /* Broadwell can sample from fast-cleared images */ > > + } else if (GEN_GEN >= 8) { > > + /* Broadwell/Skylake can sample from fast-cleared images > > */ > > att_state->input_aux_usage = ISL_AUX_USAGE_CCS_D; > > This doesn't work in all cases. SKL can only sample from CCS_D if the > format is supported for CCS_E. > It is already covered. The 'if' condition before this is triggered only if gen9+ and format doesn't support CCS_E, so if you end up here in gen9+ is because the format supports CCS_E. You're right. Sorry about that. Let's go with your patch. Reviewed-by: Nanley Chery <[email protected]> > By the way, I actually have a work-in-progress branch that has a > patch to do this: > https://cgit.freedesktop.org/~nchery/mesa/commit/?h=ccs-layouts/1-ccs > d-layout&id=e428f44e1835cb00f52848d09350957ef6f73495 > This is a similar solution to this bug. If you prefer to stick with yours, please add my R-b to it: Reviewed-by: Samuel Iglesias Gonsálvez <[email protected]> Sam
_______________________________________________ mesa-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/mesa-dev
