On Thu 30 Mar 2017, Jason Ekstrand wrote: > On Thu, Mar 30, 2017 at 11:27 AM, Chad Versace <[email protected]> > wrote: > > > On Mon 13 Mar 2017, Jason Ekstrand wrote: > > > There's really nothing for us to do here. So long as the user doesn't > > > set any crazy environment variables such as INTEL_VK_HIZ=false, all of > > > the compression formats etc. should "just work" at least for opaque > > > handle types. > > > > I think the commit message should go with the opaque fd commit. This > > patch's commit message should say something like, > > > > Turn it on. Trivially correct. Don't support any > > VkExternalMemoryHandleTypes yet. > > > > Good call. I wrote: > > This is the trivial implementation that just exposes the extension > string but exposes zero external handle types. > > I moved the other comment to the external_memory_fd commit. > > > > but in real sentences ;)
Cool. I see the updated commit on your branch. Reviewed-by: Chad Versace <[email protected]> _______________________________________________ mesa-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/mesa-dev
