On Wed, Apr 5, 2017 at 1:42 PM, Emil Velikov <[email protected]> wrote: > On 5 April 2017 at 13:37, Rob Clark <[email protected]> wrote: >> On Wed, Apr 5, 2017 at 8:25 AM, Emil Velikov <[email protected]> >> wrote: >>> From: Emil Velikov <[email protected]> >>> >>> Honour the LIBUNWIND_CFLAGS and include the header only where needed. >> >> Please drop the part other than the Makefile.am hunk.. >> > Ack, will push only the Makefile hunk. > >> I'm about to need libunwind.h included in the header file. >> > A even better solution would be is to make struct debug_stack_frame > opaque and let debug_backtrace_capture() [mc]alloc in there. > This will allow you to keep all the platform specifics in a single file, > > Will you be interested in trying that ?
I had that idea initially (there is even an ancient TODO in the code), but debug_stack_frame is embedded in a bunch of places.. so it would take a bit of an overhaul of the debug_stack_frame API unfortunately.. BR, -R _______________________________________________ mesa-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/mesa-dev
