Emil Velikov <emil.l.veli...@gmail.com> writes: > From: Emil Velikov <emil.veli...@collabora.com> > > The env variable was useful in the early days of mesa development, when > tools such at Apitrace were not available. > > Nowadays, out of the 12 options only a third are used. With nearly all > instances printing the API state. And even then not all entry points > are annotated, thus one cannot rely upon it. > > The current patch removes the variable all together alongside a few > instances (listed below) which developers may see value in keeping. > > FLUSH_VERTICES/FLUSH_CURRENT macros in src/mesa/main/context.h > _mesa_GetGraphicsResetStatusARB in src/mesa/main/robustness.c > _mesa_print_state() in src/mesa/main/state.c > _mesa_notifySwapBuffers() in src/mesa/main/context.c > > Do we want to keep any of the MESA_VERBOSE instances? If so documenting > the variable seems reasonable.
FWIW, I'm happy to see VERBOSE_API go. I've never used it, because I don't trust it. If we wanted to support it, I'd rather we worked on some sort of dispatch table stacking so that we could code-gen the VERBOSE_API printfs.
signature.asc
Description: PGP signature
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
