>On 2017-04-26 06:23, Eric Engestrom wrote: > > >Perfect, thanks! >I left a couple comments on 0658cf3db95c77dbe590. > Ok, I will focus on fixing the issues pointed out.
>> >> Foot Note: Some changes are still necessary because some specification files >> (patents.txt, libGL.txt, features.txt, etc) >> need to be exported directly to the output folder. > >I see you added a commit since your email (922e597521833875c9e5), which >essentially exports all these files to the website. >I'd argue most (if not all) of these files only make sense in the repo, >not on the website, so I think that commit can be dropped. I understand that those files are not essential, but would be nice if we can leave them in the website, as Search Engines have already linked it. > >I suggest you fix any issue from now on with `--fixup` commits (I'm >taking back my rebasing suggestion), and I'll squash those when merging. >This way, comments left on github commits won't be lost by rebasing. > >I'll also squash your 3 "fix issue with sphinx-generator" with their >respective file commits. Ok, my next commits will use `--fixup`. Thanks for the suggestion :) _______________________________________________ mesa-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/mesa-dev
