On Thu, Apr 27, 2017 at 1:32 PM, Kenneth Graunke <kenn...@whitecape.org> wrote: > On Monday, April 24, 2017 12:29:32 PM PDT Jason Ekstrand wrote: >> This seems like something that would be more appropriate to put on a >> "getting started" page than autogen.sh. The very last thing I (as a user >> of it) would expect autogen.sh to do is monkey with my git config; local or >> otherwise. > > Yeah, I don't really like this either. > > Emil is right that xserver does this - but actually to set the subject > prefix to "PATCH xserver" rather than send-email's "to" field. > > So I guess there's some precedent. Still seems odd. You almost want > a post-clone hook. But no such thing exists in git today, as far as I > can tell...and generally you don't want it executing arbitrary code you > just cloned from the internet without giving you an opportunity to read > it first...so not sure if they'd add one... >
I kinda like it.. maybe it is a bit hacky in autogen.sh, but there isn't really a better place. Perhaps a compromise would be first time autogen.sh is run, iff interactive, then prompt asking if you want to configure sendemail.to (and I guess it could also ask about sendemail.cccmd too?) BR, -R _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
