Hi all, It has bugged me for quite some time that this code is duplicated between radeonsi and radv. Also, I wanted to play around with addrlib, and for that it was helpful to have the code extracted from the various winsys structures. So this series moves the surface code into amd/common and changes both radeonsi and radv to use it instead of their own copies.
I have tested both radeonsi and radv, though the radv testing was very cursory. You can find the whole series in this branch: https://cgit.freedesktop.org/~nh/mesa/log/?h=addrtool Please review! Thanks, Nicolai -- src/amd/Makefile.common.am | 2 + src/amd/Makefile.sources | 6 + src/amd/common/ac_gpu_info.c | 291 +++++ src/amd/common/ac_gpu_info.h | 106 ++ src/amd/common/ac_surface.c | 1059 ++++++++++++++++ src/amd/common/ac_surface.h | 220 ++++ src/amd/vulkan/radv_device.c | 62 +- src/amd/vulkan/radv_image.c | 81 +- src/amd/vulkan/radv_meta_clear.c | 2 +- src/amd/vulkan/radv_meta_resolve.c | 2 +- src/amd/vulkan/radv_private.h | 5 +- src/amd/vulkan/radv_radeon_winsys.h | 144 +-- src/amd/vulkan/radv_wsi.c | 2 +- .../vulkan/winsys/amdgpu/radv_amdgpu_cs.c | 2 +- .../winsys/amdgpu/radv_amdgpu_surface.c | 468 +------ .../winsys/amdgpu/radv_amdgpu_surface.h | 1 - .../winsys/amdgpu/radv_amdgpu_winsys.c | 295 +---- .../winsys/amdgpu/radv_amdgpu_winsys.h | 4 +- .../drivers/radeon/r600_pipe_common.c | 4 +- src/gallium/drivers/radeon/radeon_winsys.h | 210 +-- src/gallium/winsys/amdgpu/drm/Makefile.am | 4 +- .../winsys/amdgpu/drm/amdgpu_surface.c | 929 +------------- .../winsys/amdgpu/drm/amdgpu_winsys.c | 323 +---- .../winsys/amdgpu/drm/amdgpu_winsys.h | 3 - .../winsys/radeon/drm/radeon_drm_winsys.c | 4 +- 25 files changed, 1826 insertions(+), 2403 deletions(-) _______________________________________________ mesa-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/mesa-dev
