I'm personally fine with this. I have never hit this _mesa_problem()
path, or maybe one time but it was me doing something dumb.
Except a comment on patch 1, this series is:
Reviewed-by: Samuel Pitoiset <samuel.pitoi...@gmail.com>
On 05/09/2017 05:04 AM, Timothy Arceri wrote:
There is still more that can be removed I just though I'd get comments before
going too far.
This is a follow on from [1][2].
Besides patch 1 we are just replacing it with an unreachable() when the
path doesn't try to work around the problem i.e return early.
_mesa_problem() is still useful in some places such as is if a backend
compile fails, but for the majority of cases we should be able to
remove it. I did a search and we haven't really added _mesa_problem()
much in recent years, most of these have existed for a really long
time.
OpenGL test suites are becoming very mature, we should place more
trust in debug builds picking up missed cases.
[1] https://patchwork.freedesktop.org/patch/154888/
[2] https://patchwork.freedesktop.org/patch/155094/
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
