On 12/20/2011 04:41 PM, Paul Berry wrote: > This makes it easier to keep track of which dirty bits correspond to > which pieces of context, since it makes _NEW_RASTERIZER_DISCARD > correspond with ctx->RasterDiscard. > --- > src/mesa/drivers/dri/i965/brw_gs.c | 5 +++-- > src/mesa/main/enable.c | 2 +- > src/mesa/main/mtypes.h | 6 ++++++ > src/mesa/state_tracker/st_atom_rasterizer.c | 4 ++-- > 4 files changed, 12 insertions(+), 5 deletions(-)
This looks good to me. I found this in the GL 3.0 spec (page 130 in the PDF) today: "RASTERIZER_DISCARD also affects the DrawPixels, CopyPixels, Bitmap, Clear, and Accum commands." This tells me that it's not transform feedback specific, so I think it shouldn't be in the gl_context::TransformFeedback struct. Yet, there's no better struct to put it in. So, a lone field in gl_context, like you've done here. For both patches: Reviewed-by: Kenneth Graunke <[email protected]> _______________________________________________ mesa-dev mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/mesa-dev
