On Wed, Jul 5, 2017 at 5:14 PM, Chad Versace <[email protected]> wrote: > On Fri 30 Jun 2017, Rob Herring wrote: >> Add support for 32-bit RGBX/RGBA formats which are required for Android. >> >> The original patch (commit ccdcf91104a5) was reverted (commit >> c0c6ca40a25e) in mesa as it broke GLX resulting in swapped colors. Based >> on further investigation by Chad Versace, moving the RGBX/RGBA configs >> to the end is enough to prevent breaking GLX. >> >> Cc: Marek Olšák <[email protected]> >> Cc: Eric Anholt <[email protected]> >> Cc: Chad Versace <[email protected]> >> Cc: Mauro Rossi <[email protected]> >> Signed-off-by: Rob Herring <[email protected]> >> --- >> I've tested only on Android and could use help testing with KDE which >> broke last time. This has been done on the Intel driver and *should* be >> okay, but maybe not. > > Should this patch also update the switch statement in > dri2.c:dri2_drawable_get_buffers()? I think so, but am not certain.
I don't know. At least for Android, I think we'd always take the dri_image_drawable_get_buffers path which already has the formats. Rob _______________________________________________ mesa-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/mesa-dev
